Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix e2e fixtures and 1.9.3 unit tests #538

Merged
merged 2 commits into from
Apr 29, 2019
Merged

Fix e2e fixtures and 1.9.3 unit tests #538

merged 2 commits into from
Apr 29, 2019

Conversation

Cawllec
Copy link
Contributor

@Cawllec Cawllec commented Apr 26, 2019

Goal

  • Adds gem requirements for Ruby 1.9.3 to ensure unit tests run
  • Fixes SQLite3 version in Rails fixtures for e2e tests

tobyhs
tobyhs approved these changes Apr 26, 2019
View reviewed changes
Copy link
Contributor

@tobyhs tobyhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

features/fixtures/rails5/app/Gemfile
@@ -4,7 +4,7 @@ source 'https://rubygems.org'
# Bundle edge Rails instead: gem 'rails', github: 'rails/rails'
gem 'rails', '~> 5.0.0'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Rails 5.2.3 has the fix for the sqlite3 version dependency, but this dependency here won't go up to 5.2. We should probably consider adding or changing this some day.

@Cawllec Cawllec merged commit eaef01a into master Apr 29, 2019
@Cawllec Cawllec deleted the test-fixes branch April 29, 2019 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobyhs tobyhs tobyhs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Cawllec @tobyhs