Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't call extra tracking data twice #586

Merged
merged 2 commits into from Apr 30, 2020
Merged

Conversation

stoivo
Copy link
Contributor

@stoivo stoivo commented Mar 24, 2020

Goal

I noticed that it was calling my method custom data extractor twice. We did't do much data processing the that code so no harm.

Tests

I did add or change any spec since the behavour is the exact same as before.

Discussion

Review

For the submitter, initial self-review:

  • Commented on code changes inline explain the reasoning behind the approach
  • Reviewed the test cases added for completeness and possible points for discussion
  • A changelog entry was added for the goal of this pull request
  • Check the scope of the changeset - is everything in the diff required for the pull request?
  • This pull request is ready for:
    • Initial review of the intended approach, not yet feature complete
    • Structural review of the classes, functions, and properties modified
    • Final review

For the pull request reviewer(s), this changeset has been reviewed for:

  • Consistency across platforms for structures or concepts added or modified
  • Consistency between the changeset and the goal stated above
  • Internal consistency with the rest of the library - is there any overlap between existing interfaces and any which have been added?
  • Usage friction - is the proposed change in usage cumbersome or complicated?
  • Performance and complexity - are there any cases of unexpected O(n^3) when iterating, recursing, flat mapping, etc?
  • Concurrency concerns - if components are accessed asynchronously, what issues will arise
  • Thoroughness of added tests and any missing edge cases
  • Idiomatic use of the language

@mattdyoung
Copy link

Hi @stoivo

Thanks for the PR! We'll look into incorporating this when priorities allow.

@mattdyoung mattdyoung added the bug Confirmed bug label Mar 27, 2020
@bugsnagbot bugsnagbot added the scheduled Work is starting on this feature/bug label Apr 30, 2020
@imjoehaines imjoehaines changed the base branch from master to next April 30, 2020 14:17
Copy link
Member

@imjoehaines imjoehaines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stoivo!

@imjoehaines imjoehaines merged commit f05d9ea into bugsnag:next Apr 30, 2020
imjoehaines added a commit that referenced this pull request Apr 30, 2020
@mattdyoung
Copy link

Now released in v6.13.1

@mattdyoung mattdyoung added released This feature/bug fix has been released and removed scheduled Work is starting on this feature/bug labels May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bug released This feature/bug fix has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants