Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce gem size #621

Merged
merged 3 commits into from
Aug 5, 2020
Merged

Reduce gem size #621

merged 3 commits into from
Aug 5, 2020

Conversation

imjoehaines
Copy link
Member

Goal

This is #571 with CI passing — we need to include the gemspec file in order for our Docker setup to work

Tests

This is tested by the Maze Runner tests as they build, unpack and install the Gem before running

Review

For the submitter, initial self-review:

  • Commented on code changes inline explain the reasoning behind the approach
  • Reviewed the test cases added for completeness and possible points for discussion
  • A changelog entry was added for the goal of this pull request
  • Check the scope of the changeset - is everything in the diff required for the pull request?
  • This pull request is ready for:
    • Initial review of the intended approach, not yet feature complete
    • Structural review of the classes, functions, and properties modified
    • Final review

For the pull request reviewer(s), this changeset has been reviewed for:

  • Consistency across platforms for structures or concepts added or modified
  • Consistency between the changeset and the goal stated above
  • Internal consistency with the rest of the library - is there any overlap between existing interfaces and any which have been added?
  • Usage friction - is the proposed change in usage cumbersome or complicated?
  • Performance and complexity - are there any cases of unexpected O(n^3) when iterating, recursing, flat mapping, etc?
  • Concurrency concerns - if components are accessed asynchronously, what issues will arise
  • Thoroughness of added tests and any missing edge cases
  • Idiomatic use of the language

t-richards and others added 3 commits August 3, 2020 13:57
These are needed to be able to install the Gem from the built gemfile
@imjoehaines imjoehaines marked this pull request as ready for review August 3, 2020 13:42
@imjoehaines imjoehaines mentioned this pull request Aug 3, 2020
15 tasks
@imjoehaines imjoehaines merged commit 8182fa5 into next Aug 5, 2020
@imjoehaines imjoehaines deleted the reduce-gem-size branch August 12, 2020 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants