Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes, warnings, RSpec upgrades for the future #86

Merged
merged 8 commits into from Apr 2, 2014

Conversation

blackxored
Copy link
Contributor

No description provided.

* travis-1.8-rake:
  Attempt for travis in 1.8 ruby
@ConradIrwin ConradIrwin merged commit 9de877c into bugsnag:master Apr 2, 2014
@ConradIrwin
Copy link
Contributor

@blackxored Thanks again for all your hard work.

In future, could you try to break things down a little bit more. I don't mind reviewing 5 pull requests when they're all tiny, but one huge one that refactors all the tests, fixes some bugs, and does some misc cleanup feels like a lot more effort to review :).

@blackxored
Copy link
Contributor Author

Well they were related, but you're right ;)

On Wed, Apr 2, 2014 at 9:55 AM, Conrad Irwin notifications@github.comwrote:

@blackxored https://github.com/blackxored Thanks again for all your
hard work.

In future, could you try to break things down a little bit more. I don't
mind reviewing 5 pull requests when they're all tiny, but one huge one that
refactors all the tests, fixes some bugs, and does some misc cleanup feels
like a lot more effort to review :).

Reply to this email directly or view it on GitHubhttps://github.com//pull/86#issuecomment-39297912
.

Best Regards,

Adrian Perez
http://www.adrianperez.org
Twitter: @blackxored | Skype: blackxored | Phone: +1 (559) 744-3201

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants