Added auto user detection and more config options #12
Conversation
|
Ok, done the path stuff here too. |
| return; | ||
| } | ||
|
|
||
| $base = realpath(__DIR__.'/../../../../'); |
There was a problem hiding this comment.
Shouldn’t there be directory separators here instead of concatenating forward slashes?
There was a problem hiding this comment.
Yeh, lol. SIlex has no way to know the app path, which is why I didn't add this originally, but Simon said it would be nice to have this working if we could, so I went with this.
This works on the assumption that the structure is vendor/bugsnag/bugsnag-silex/src/AbstractServiceProvider.php, and then the rest of the project is in the same directory as vendor, including an src folder with the main app code in it.
The nice thing about realpath is it will return false if the path doesn't exist, so if someone has messed with the directories, then we should be ok. :)
There was a problem hiding this comment.
No, it's ok. PHP should normalize the slashes within the realpath function.
This brings us up to feature parity with the symfony notifier other than automatically detecting the strip path and project root, however, that has been mitigated in the docs, but, I do have an idea for how to properly fix that. Will PR after this has gone through.