Prevent asbolute webpack:/// paths from being relatively resolved

bugsnag · Nov 1, 2019 · c776d2d · c776d2d
1 parent 95acc11
commit c776d2d
Show file tree

Hide file tree

Showing 4 changed files with 39 additions and 0 deletions.
diff --git a/lib/options.js b/lib/options.js
@@ -103,6 +103,9 @@ function transformSourcesMap (options) {
     readFileJSON(options.sourceMap)
       .then(sourceMap => (
         mapSources(sourceMap, p => {
+          // don't transform any webpack paths
+          if (/^webpack:\/\//.test(p)) return p
+
           // resolve a relative path in the sources array
           const resolvedPath = path.resolve(path.dirname(options.sourceMap), p)
 

diff --git a/test/fixtures/webpack/main.js b/test/fixtures/webpack/main.js
diff --git a/test/fixtures/webpack/main.js.map b/test/fixtures/webpack/main.js.map
diff --git a/test/index.test.js b/test/index.test.js
@@ -147,3 +147,36 @@ test('multiple uploads (resolving relative source paths inside map)', () => {
     ])
   })
 })
+
+test('webpack paths', () => {
+  let mockCalled = 0
+  let mockCalledWith = []
+  const mockConcat = concat
+  jest.mock('../lib/request', () => {
+    return (endpoint, makePayload, onSuccess, onError) => {
+      mockCalled++
+      const payload = makePayload()
+      payload.sourceMap.pipe(mockConcat(data => {
+        payload.sourceMapData = JSON.parse(data)
+        mockCalledWith.push(payload)
+        onSuccess()
+      }))
+    }
+  })
+
+  const upload = require('../').upload
+  return upload({
+    apiKey: 'API_KEY',
+    projectRoot: `${__dirname}/fixtures/webpack`,
+    sourceMap: `${__dirname}/fixtures/webpack/main.js.map`,
+    minifiedFile: `${__dirname}/fixtures/webpack/main.js`,
+    minifiedUrl: 'http://yeah.no/bundle.js'
+  }).then(() => {
+    expect(mockCalled).toBe(1)
+
+    expect(mockCalledWith[0].sourceMapData.sources).toEqual([
+      'webpack:///webpack/bootstrap',
+      'webpack:///./src/index.js'
+    ])
+  })
+})