Tom/rollup changes

[tomlongridge]

Goal

Contains fixes contributed by @fiskhandlarn and @chrisatomix to remove deprecation warnings when setting options and to make API key settable from wp-config. Also fixes broken links on settings page referencing the dashboard and account sign-up.

Changeset

Changed

• bugsnag.php - added bugsnag_define_api_key method and filter to wrap calls to get API key option and return define, if set.
• bugsnag.php - made bugsnagWordpress global for use in CLI scripts (see $bugsnagWordpress variable not available on CLI scripts #23)
• views/settings.php - removed the form action as per recommendation.
• views/settings.php - fixed references to bugsnag.com

Tests

• Both changes manually tested with WP 5.2.2

Review

For the submitter, initial self-review:

• Commented on code changes inline explain the reasoning behind the approach
• Reviewed the test cases added for completeness and possible points for discussion
• A changelog entry was added for the goal of this pull request
• Check the scope of the changeset - is everything in the diff required for the pull request?
• This pull request is ready for:
  • Initial review of the intended approach, not yet feature complete
  • Structural review of the classes, functions, and properties modified
  • Final review

For the pull request reviewer(s), this changeset has been reviewed for:

• Consistency across platforms for structures or concepts added or modified
• Consistency between the changeset and the goal stated above
• Internal consistency with the rest of the library - is there any overlap between existing interfaces and any which have been added?
• Usage friction - is the proposed change in usage cumbersome or complicated?
• Performance and complexity - are there any cases of unexpected O(n^3) when iterating, recursing, flat mapping, etc?
• Concurrency concerns - if components are accessed asynchronously, what issues will arise
• Thoroughness of added tests and any missing edge cases
• Idiomatic use of the language

[Cawllec]

LGTM