Timeout : return an error compatible with os.IsTimeout()

[maitredede]

Like *net.Conn.Read() or *os.File.Read() when a timeout occurs, return an error that can be checked with os.IsTimeout()

[maitredede]

The actual behavior is "return 0 without error", that can also be understood as "end of stream". Network connections and file reads have their own timeout errors that can be detected with os.IsTimeout().

[zeroZshadow]

This is exactly the issue i'm running into. I'm using io.ReadFull to fill a buffer directly from the port. However if a timeout is hit due to misconfiguration, it will loop forever.
Thanks for fixing this!

[quite]

@maitredede do you have time to rebase this?

[quite]

I think case Timeout:; return "Timeout" should also be added before default: (bcaab3f#diff-ad4fb56affb62e9f5024c32ea8a857376661813e1bc22b7dfef64f21ff16c34fR176)

[quite]

Done

[quite]

@maitredede i you don't have time, i think i can take over with a new PR (keeping you as author of course).

[maitredede]

Hello @quite, I have rebased/updated 😃

[quite]

@maitredede great! I hope @cmaglie will get some time to look over this and merge it