Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speedup dependency resolver by analizying fruitless branches first #15

Merged
merged 3 commits into from
May 30, 2023

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented May 30, 2023

This change helps not to get stuck in a loop when analyzing cases similar to #14 but with the unsuccessful branch that can not be pre-cut because buried deep in the dependency tree:

A
\__ B (1.0.0, 1.0.1, 1.0.2, 1.0.3, 1.0.4)
     \__ C (1.0.0, 1.0.1, 1.0.2, 1.0.3, 1.0.4)
          \__ D (1.0.0, 1.0.1, 1.0.2, 1.0.3, 1.0.4)
          \__ E (1.0.0, 1.0.1, 1.0.2, 1.0.3, 1.0.4)
          \__ F (1.0.0, 1.0.1, 1.0.2, 1.0.3, 1.0.4)
          \__ G (1.0.0, 1.0.1, 1.0.2, 1.0.3, 1.0.4)
          \__ H (1.0.0, 1.0.1, 1.0.2, 1.0.3, 1.0.4)
          \__ I (dependency not available)

BTW this change does not fix the worst case, it moves it further away, but it's still possible.
A better strategy must be implemented for more complex scenarios.

@cmaglie cmaglie added the enhancement New feature or request label May 30, 2023
@cmaglie cmaglie self-assigned this May 30, 2023
@cmaglie cmaglie changed the title Speedup dependency resolver by analizying fuitless branch first Speedup dependency resolver by analizying fruitless branches first May 30, 2023
@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Merging #15 (7cce8cf) into master (df298c3) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #15   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          815       828   +13     
=========================================
+ Hits           815       828   +13     
Impacted Files Coverage Δ
resolver.go 100.00% <100.00%> (ø)

@cmaglie cmaglie merged commit 8151b13 into master May 30, 2023
5 checks passed
@cmaglie cmaglie deleted the speedup branch May 30, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants