Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added YAML support #16

Merged
merged 3 commits into from
Jul 3, 2023
Merged

Added YAML support #16

merged 3 commits into from
Jul 3, 2023

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Jul 3, 2023

Since I'm there, I've fixed some JSON unit-test too.

@cmaglie cmaglie self-assigned this Jul 3, 2023
@codecov
Copy link

codecov bot commented Jul 3, 2023

Codecov Report

Merging #16 (8f4804c) into master (8151b13) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 8f4804c differs from pull request most recent head 4fe18c9. Consider uploading reports for the commit 4fe18c9 to get more accurate results

@@            Coverage Diff            @@
##            master       #16   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        11    +1     
  Lines          828       858   +30     
=========================================
+ Hits           828       858   +30     
Impacted Files Coverage Δ
yaml.go 100.00% <100.00%> (ø)

Copy link

@kittaakos kittaakos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great. There are new tests for YAML. Thank you!

I have noticed the copyright still shows 2022 in the new files.

README.md Outdated Show resolved Hide resolved
Co-authored-by: Umberto Baldi <34278123+umbynos@users.noreply.github.com>
@cmaglie cmaglie merged commit 947a2f3 into master Jul 3, 2023
3 checks passed
@cmaglie cmaglie deleted the yamlsupport branch July 3, 2023 15:26
@per1234 per1234 added the enhancement New feature or request label Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants