Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force kill script is the first click on stop doesn't stop the script #146

Closed
csphoenix1 opened this issue Dec 10, 2018 · 3 comments
Closed

Comments

@csphoenix1
Copy link
Contributor

Hi !

Is it possible to add the possibility to force kill a script if the first try of stopping the script doesn't work?

Actualy, I think it's a SIGINT or SIGTERM which is sent.
Maybe, on the second time the user click on STOP, we can send a SIGKILL ?

Use case: recently, I develop a python script which prompt a message box is there is a problem.
The problem is through Script-Server, the message box was not displayed. So the script was stuck. So I click on STOP but the script doesn't stop.
I think it could be cool if on the force click on STOP, the button change to "KILL" and if I click on it, it kill the script? :)

@bugy
Copy link
Owner

bugy commented Dec 10, 2018

Hi @csphoenix1, nice and simple idea and it should be pretty easy to implement (I even have API for it and it's even called when you log out).
But I would rather make it with a timer (let say 5 sec) to give a script a chance to stop gracefully :) I.e. you press stop, then a button disables for 5 sec and after 5 sec you can kill it.

@bugy bugy added the feature label Dec 10, 2018
@csphoenix1
Copy link
Contributor Author

Hi @bugy,
About the timer, if we are in a test period where we test a script which we known an INT will not work and we will do a KILL each time during this test period, a timer of 5s can be boring.
But I understand that if a user click multiple times in STOP, he will click on KILL by mistake.
So... maybe we can simply add a KILL button in more of STOP button. Like that, no mistake is possible. And we can choose always STOP or KILL the process :)

@bugy bugy added the resolved label Aug 20, 2019
@bugy bugy added this to the 1.15.0 milestone Aug 20, 2019
@bugy
Copy link
Owner

bugy commented Aug 20, 2019

For not I decided to go with a timer. Let's see how it goes, and if it will be too boring or annoying or whatever, we come back to it again.

@bugy bugy closed this as completed Feb 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants