Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Server responds with 404 if runner name contains a slash #237

Closed
xotonic opened this issue Oct 9, 2019 · 2 comments
Closed

Server responds with 404 if runner name contains a slash #237

xotonic opened this issue Oct 9, 2019 · 2 comments
Labels
bug resolved
Milestone
1.15.0

Comments

@xotonic
Copy link

xotonic commented Oct 9, 2019

sample_runner.json

{
"name" : "I contain a slash /",
...
}

Log:

2019-10-09 00:39:07,962 [tornado.access.WARNING] 404 GET /scripts/I%20contain%20a%20slash%20/ (46.33.214.58) 1.04ms
@bugy
Copy link
Owner

bugy commented Oct 9, 2019

Hi @xotonic thanks for reporting!

@bugy bugy added the bug label Oct 9, 2019
bugy added a commit that referenced this issue Nov 10, 2019
@bugy
#237 fixed loading scripts with a slash in the name
6c35839
@bugy bugy added the resolved label Nov 10, 2019
@bugy
Copy link
Owner

bugy commented Nov 10, 2019

Fixed

@bugy bugy added this to the 1.15.0 milestone Nov 10, 2019
@bugy bugy closed this as completed Feb 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug resolved
Projects
None yet
Milestone
1.15.0
Development

No branches or pull requests
2 participants
@bugy @xotonic