Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows + python 3.8: server start fails with NotImplementedError #251

Closed
bugy opened this issue Dec 29, 2019 · 1 comment
Closed

Windows + python 3.8: server start fails with NotImplementedError #251

bugy opened this issue Dec 29, 2019 · 1 comment

Comments

@bugy
Copy link
Owner

bugy commented Dec 29, 2019

If you try to run Script server on Windows machine, using python3.8, it fails with

2019-12-29 23:10:05,951 [asyncio.DEBUG] Using proactor: IocpProactor
Traceback (most recent call last):
  File "script-server\launcher.py", line 11, in <module>
    main.main()
  File "src\main.py", line 124, in main
    server.init(
  File "src\web\server.py", line 909, in init
    http_server.listen(server_config.port, address=server_config.address)
  File "Python38-32\lib\site-packages\tornado\tcpserver.py", line 152, in listen
    self.add_sockets(sockets)
  File "Python38-32\lib\site-packages\tornado\tcpserver.py", line 165, in add_sockets
    self._handlers[sock.fileno()] = add_accept_handler(
  File "Python38-32\lib\site-packages\tornado\netutil.py", line 279, in add_accept_handler
    io_loop.add_handler(sock, accept_handler, IOLoop.READ)
  File "Python38-32\lib\site-packages\tornado\platform\asyncio.py", line 99, in add_handler
    self.asyncio_loop.add_reader(fd, self._handle_events, fd, IOLoop.READ)
  File "Python38-32\lib\asyncio\events.py", line 501, in add_reader
    raise NotImplementedError
@bugy bugy added the bug label Dec 29, 2019
@bugy bugy added this to the 1.15.0 milestone Dec 29, 2019
@bugy
Copy link
Owner Author

bugy commented Dec 29, 2019

The reason (and the fix) is tornadoweb/tornado#2608

bugy added a commit that referenced this issue Jan 1, 2020
bugy added a commit that referenced this issue Jan 1, 2020
@bugy bugy added the resolved label Jan 1, 2020
@bugy bugy closed this as completed Feb 1, 2020
antonellocaroli pushed a commit to antonellocaroli/script-server that referenced this issue Aug 1, 2020
antonellocaroli pushed a commit to antonellocaroli/script-server that referenced this issue Aug 1, 2020
antonellocaroli pushed a commit to antonellocaroli/script-server that referenced this issue Aug 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant