Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contract.allFrom abstract solidity contracts #54

Closed
3Nigma opened this issue Apr 10, 2022 · 0 comments
Closed

Contract.allFrom abstract solidity contracts #54

3Nigma opened this issue Apr 10, 2022 · 0 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request
Milestone

Comments

@3Nigma
Copy link
Contributor

3Nigma commented Apr 10, 2022

Permit loading of abstract contracts even though, by default, this won't result in any byteCode being generated by the Solidity compiler.

So, for example, the following solidity contract:

abstract contract SimpleStorage {
    uint public num;

    function set(uint _num) public {
        num = _num;
    }

    function get() public view returns (uint) {
        return num;
    }
}

even though all of its methods have an implementation, will result in its solo.evm.bytecode.object being ''. Even though it will correctly extract the ABI.

We are allowing this mostly so that the ContractRegistry is able to get generated correctly when bundling (it only needs the ABI in this scenario).

When this is the case, be sure not to allow uploading of the Contract through a ApiSession in an attempt to make it live.

@3Nigma 3Nigma added bug Something isn't working enhancement New feature or request labels Apr 10, 2022
@3Nigma 3Nigma added this to the 0.7.4 milestone Apr 10, 2022
@3Nigma 3Nigma self-assigned this Apr 10, 2022
3Nigma added a commit that referenced this issue Apr 10, 2022
victorholo added a commit that referenced this issue Apr 11, 2022
…ding

Allowing `Contract.allFrom` to load abastract solidity contracts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants