New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thanks! #1

Open

olivernadj opened this issue May 8, 2019 · 0 comments

olivernadj commented May 8, 2019

Hi @buihdk,
thanks for your submission. Let me leave some comment here.

Things you did well:

You've organized the code well. It was easy to read.
You've used Go 1.12 Modules

Things to work on:

Take attention to imports, use github.com/your-account/your-assignment

If you have time, please make up the lab: https://gist.github.com/olivernadj/d78dd8fbd0d1e0a2f597d3c457165f70 you probably would do the project differently after this lab.

Overall, good work! You are demonstrating that you are understanding the material and doing a great job of applying it. Keep it up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment