Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to guess the CI server from the URL #21

Closed
GentlemanHal opened this issue Nov 27, 2014 · 3 comments
Closed

Attempt to guess the CI server from the URL #21

GentlemanHal opened this issue Nov 27, 2014 · 3 comments
Labels
improvement Changes that improve an existing feature

Comments

@GentlemanHal
Copy link
Member

This will allow us to add specific parsing options for that particular CI server, currently this is only important for Go and Snap.

Now we always try and perform the Go/Snap specific parsing.

We could also just ask on the config screen but working it out automatically seems nicer if we can consistently.

@GentlemanHal GentlemanHal added the improvement Changes that improve an existing feature label Nov 27, 2014
@joejag
Copy link
Contributor

joejag commented Dec 3, 2014

So we would no longer get a {job: null, state: null} in the api calls when we use a Jenkins?

Are there any other benefits or bugs this would allow for?

@GentlemanHal
Copy link
Member Author

Right now that would be the only obvious change.

Going forward I'd be surprised if Go/Snap where the only things that required some specific processing.

@joejag
Copy link
Contributor

joejag commented Dec 3, 2014

Yeah, I'd like to try out every CI server (that's where the Travis SSL issue came from), let's keep this issue open until we've tested with each.

@joejag joejag closed this as completed in 72437f3 Dec 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Changes that improve an existing feature
Projects
None yet
Development

No branches or pull requests

2 participants