Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

You can still change tabs while project list is loading #50

Closed
GentlemanHal opened this issue Jan 30, 2015 · 3 comments
Closed

You can still change tabs while project list is loading #50

GentlemanHal opened this issue Jan 30, 2015 · 3 comments
Labels
bug Something isn't working as expected
Milestone

Comments

@GentlemanHal
Copy link
Member

The loading spinner overlay should block the entire page until the call returns

@GentlemanHal GentlemanHal added the bug Something isn't working as expected label Jan 30, 2015
@cowley05
Copy link
Contributor

not sure this is actually a bug? Ive tried to cause problems when this happens but i couldnt break it and since the monitor page redirects you back if there are no projects it doesnt break that either, even if it fails to fetch you just see the error failed to fetch on monitor. I dont think its a problem that you can go edit the success or timing whilst its fetching.

thoughts???

@GentlemanHal
Copy link
Member Author

My internet at home can be very slow so that gave me enough time to be able to mess with the page.

I'd imagine If you are on a slow connection fetching a large xml you could replicate.

@GentlemanHal
Copy link
Member Author

Since the React refactor the loading of projects is tied nicer into the mounting of sections into the DOM.

I don't think this bug is relevant anymore, so I'm going to close it. Feel free to reopen if you disagree.

@GentlemanHal GentlemanHal modified the milestone: v0.6.0 Apr 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as expected
Projects
None yet
Development

No branches or pull requests

2 participants