Improve ockam secure-channel create to support --from /node/NAME syntax

[mrinalwadhwa]

Currently

> ockam node create n1
...
> ockam node create n2
...
> ockam secure-channel create --from n1 --to /node/n2/service/api

Desired

We also want to support --from /node/n1

> ockam node create n1
...
> ockam node create n2
...
> ockam secure-channel create --from /node/n1 --to /node/n2/service/api

The code for the ockam secure-channel create is:
https://github.com/build-trust/ockam/blob/develop/implementations/rust/ockam/ockam_command/src/secure_channel/create.rs

[michealkeines]

Hi @mrinalwadhwa

I am assuming the input node name will always be in end of the protocol

Eg:
/node/n1
/node/test_node

If this is true,

sample code

output:

do you have other ways on how to approach this?

[mrinalwadhwa]

@michealkeines thank you for looking into this!

Your approach above is a great place to start 👍
Could you turn this into a helper function and place it here

Multiple other commands have options that take NODE values and we'll want to update all of them to support the /node/n1 syntax.

I'll create a list of all the commands that need this in a separate issue shortly.

[michealkeines]

Hi @mrinalwadhwa,

• Created the helper function
• Updated secure-channel create command to use the helper function

Please review my PR #3243

[mrinalwadhwa]

@michealkeines Thank you, while I look into merging #3243.

Issues #3244, #3203, #3245, #3246, #3247 and #3248 are all the same in case you want to send a follow on PR for those.

[michealkeines]

Sure, I will add them, separate PRs for all issues or should i add them all in one?

[mrinalwadhwa]

In the same PR should good 👍

[mrinalwadhwa]

Added in #3243

[mrinalwadhwa]

@michealkeines I wanted to show your change in a demo so I ended up making all the changes I suggested up. If you're interested in picking something else, have a look at some of the new issues we posted today.

Thank you for send the above PR!