Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 3205 improve from input value #3243

Merged
merged 2 commits into from
Aug 16, 2022
Merged

Issue 3205 improve from input value #3243

merged 2 commits into from
Aug 16, 2022

Conversation

michealkeines
Copy link
Contributor

@michealkeines michealkeines commented Aug 16, 2022 •
edited
Loading

Added Helper function to get node name from node path format

updated secure-channel create to use the helper function

image

Checks

@michealkeines michealkeines requested a review from a team as a code owner August 16, 2022 13:50
@michealkeines michealkeines mentioned this pull request Aug 16, 2022
Closed
@mrinalwadhwa mrinalwadhwa force-pushed the issue-3205-improve-from-input-value branch from 6c36816 to 18cd237 Compare August 16, 2022 14:29
@mrinalwadhwa
Copy link
Member

@michealkeines the changes look great.
I amended the commit messages a bit, ran cargo fmt and force pushed to your branch so please rebase accordingly for your other PR.

This one will merge shortly after the CI checks pass.

adrianbenavides
adrianbenavides previously requested changes Aug 16, 2022
View reviewed changes
Copy link
Member

@adrianbenavides adrianbenavides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I left a small comment but looks great.

implementations/rust/ockam/ockam_command/src/util/mod.rs Outdated Show resolved Hide resolved
implementations/rust/ockam/ockam_command/src/secure_channel/create.rs Outdated Show resolved Hide resolved
@adrianbenavides adrianbenavides force-pushed the issue-3205-improve-from-input-value branch from 18cd237 to d5739b2 Compare August 16, 2022 14:58
@mrinalwadhwa mrinalwadhwa force-pushed the issue-3205-improve-from-input-value branch from d5739b2 to 9cdc731 Compare August 16, 2022 15:06
@mrinalwadhwa mrinalwadhwa self-requested a review August 16, 2022 15:12
@mrinalwadhwa mrinalwadhwa dismissed adrianbenavides’s stale review August 16, 2022 15:12

adrian pushed the requested changes,

@mergify mergify bot merged commit 588440d into build-trust:develop Aug 16, 2022
@mrinalwadhwa
Copy link
Member

@michealkeines Thank you for another awesome contribution 🥳 🎈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrinalwadhwa mrinalwadhwa mrinalwadhwa approved these changes

@adrianbenavides adrianbenavides Awaiting requested review from adrianbenavides

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michealkeines @mrinalwadhwa @adrianbenavides