ci: improve installer script #3494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrinalwadhwa
force-pushed
the
mrinal/installer
branch
2 times, most recently
from
466fb7e
to
ceff711
Compare
1. remove shasum and cosign 2. improve output and help
mrinalwadhwa
force-pushed
the
mrinal/installer
branch
from
ceff711
to
f39186f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on #3488 by @danieled-it
I removed the cosign check. As I thought about it, I think there is no threat model under which that extra check is helpful. Cosign checks are useful if the user already has the ockam release public key. If they don't then first fetching the public key and then the binary from the same channel doesn't protect against any additional threats.
Same with shasum checks. If https is doing its job then validating them seems unnecessary.
In this PR I also improved the script with ideas from (MIT licensed)
https://github.com/rust-lang/rustup/blob/master/rustup-init.sh