Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add "coverage" profile to cargo #3606

Merged
merged 1 commit into from
Oct 7, 2022
Merged

build: add "coverage" profile to cargo #3606

merged 1 commit into from
Oct 7, 2022

Conversation

Overflow0xFFFF
Copy link
Contributor

@Overflow0xFFFF Overflow0xFFFF commented Oct 7, 2022

Current Behavior

Documented code coverage commands do not work.

Proposed Changes

  • Create a profile for Cargo so that rustc flags are properly passed.
  • Update documentation so that the new profile is used when generating code coverage docs.

See rust-lang/rust#78011.

Closes #3553.

Testing

This was tested locally. A copy of the generated test results are available here: coverage.zip

Checks

Cargo doesn't fully pay attention to the RUSTFLAGS variable.
As such, to pass appropriate flags to rustc, Cargo uses a profile.
We thus create a profile specifically for generating code coverage and
updating the code coverage docs accordingly.

See rust-lang/rust#78011.

Closes #3553.
@Overflow0xFFFF Overflow0xFFFF requested a review from a team as a code owner October 7, 2022 01:44
@mrinalwadhwa
Copy link
Member

@Overflow0xFFFF awesome, that worked like a charm. Thank you another fantastic contribution! 🥳

@mergify mergify bot merged commit 8b61f46 into build-trust:develop Oct 7, 2022
@mrinalwadhwa mrinalwadhwa added the HACKTOBERFEST-ACCEPTED To be used when a PR is ready to merge or after it's merged label Oct 7, 2022
@mrinalwadhwa mrinalwadhwa added HACKTOBERFEST-ACCEPTED-2022 and removed HACKTOBERFEST-ACCEPTED To be used when a PR is ready to merge or after it's merged labels Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code Coverage Tool Errors
2 participants