feat(rust): add optional --identity argument to secure-channel create #4018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mo-Fatah
force-pushed
the
identity-for-secure-channel-create
branch
from
ddb5e9e
to
c7265e2
Compare
adrianbenavides
requested changes
Jan 4, 2023
There was a problem hiding this comment.
Hey @Mo-Fatah , thanks for submitting another PR 🥳
It looks almost ready to me, but I left some comments pointing out some details that could be improved. Let me know if you have any questions.
implementations/rust/ockam/ockam_api/src/nodes/service/secure_channel.rs
Outdated
Show resolved
Hide resolved
implementations/rust/ockam/ockam_api/src/nodes/service/secure_channel.rs
Outdated
Show resolved
Hide resolved
implementations/rust/ockam/ockam_api/src/nodes/service/secure_channel.rs
Outdated
Show resolved
Hide resolved
Mo-Fatah
force-pushed
the
identity-for-secure-channel-create
branch
from
c7265e2
to
66e57d6
Compare
adrianbenavides
force-pushed
the
identity-for-secure-channel-create
branch
3 times, most recently
from
f1cdc86
to
7bf00fd
Compare
adrianbenavides
previously approved these changes
Jan 9, 2023
There was a problem hiding this comment.
Ready to merge, thanks @Mo-Fatah for another great contribution! 🥳
adrianbenavides
force-pushed
the
identity-for-secure-channel-create
branch
from
0fba7ae
to
e083b52
Compare
adrianbenavides
approved these changes
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3906
Proposed Changes
in
ockam_command: add optional --identity argument to secure-channel create. TheOption<String>argument is sent toockam_apiin the request.in
ockam_api: thecreate_secure_channel_implfunction checks if theidentityargument is provided, otherwise useself.identity()Checks