Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rust): .mode method does not exit on windows. #4030

Closed
wants to merge 5 commits into from
Closed

fix(rust): .mode method does not exit on windows. #4030

wants to merge 5 commits into from

Conversation

waqasraz
Copy link
Contributor

@waqasraz waqasraz commented Jan 5, 2023

Current Behavior

Vault does not compile on windows.

Proposed Changes

It will remove the use of .mode for windows OS.

Checks

@waqasraz waqasraz requested a review from a team as a code owner January 5, 2023 03:18
@etorreborre
Copy link
Member

Hi @waqasraz can you please rebase your commits without any merges? Thank you.

@etorreborre
Copy link
Member

etorreborre commented Feb 21, 2023

@waqasraz I am closing this PR in favour of #4303. I have added you as a co-author of the commit, thanks for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants