-
-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rust): update macos activation policy #5410
feat(rust): update macos activation policy #5410
Conversation
If you anticipate introducing more specific platform behaviour in the future, then we could also consider refactoring this PR to help improve code organization and make it easier to manage platform-specific functionalities. main.rs:
lib.rs:
macos.rs:
others.rs:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @qxtaiba! Let's apply your refactor suggestion if we end-up adding more platform specific behaviors.
@qxtaiba you need to rename your commit and prefix it with |
d9ca6cb
to
7437206
Compare
Current behavior
The macOS desktop application shows up in both the top right menu and the macOS dock.
Proposed changes
The issue that this PR fixes is described in #5365
This PR implements some platform-specific code that sets the activation policy for macOS. The activation policy is now explicitly configured to display the application only in the macOS menu bar and not in the dock.
Checks