delete node interactively

[mickm3n]

For implementing #6450

Current behavior

When a user runs ockam node delete without any arguments, currently they are prompted to delete the default node. Here's a screenshot of this.

Proposed changes

Instead of deleting the default node, change the behavior of this command so that it becomes interactive with the user. Note that this can only be allowed to happen if:

• the terminal is interactive, and,
• the --no-output or --quiet flags have not been passed, and,
• no arguments have been passed in to the command.

When there one or more nodes could be deleted, after a user runs ockam node delete, the user will see

• 
• If the user doesn't select one and press Enter, the user will see
  • 
• But if the user does select and press Enter, the user will see
  • 
  • After selecting YES
    • 

Checks

• All commits in this Pull Request are signed and Verified by Github.
• All commits in this Pull Request follow the Ockam commit message convention.
• There are no Merge commits in this Pull Request. Ockam repo maintains a linear commit history. We merge Pull Requests by rebasing them onto the develop branch. Rebasing to the latest develop branch and force pushing to your Pull Request branch is okay.
• I have read and accept the Ockam Community Code of Conduct.
• I have read and accepted the Ockam Contributor License Agreement by adding my Git/Github details in a row at the end of the CONTRIBUTORS.csv file in a separate pull request to the build-trust/ockam repository. The easiest way to do this is to edit the CONTRIBUTORS.csv file in the github web UI and create a separate Pull Request, this will mark the commit as verified.

[mickm3n]

@nazmulidris I don't know how to make node deletion fail, so I haven't tested the failed scenario. If you have any advice, I could try it.

Any advice is welcome!

[nazmulidris]

I don't know how to make node deletion fail, so I haven't tested the failed scenario. If you have any advice, I could try it. Any advice is welcome!

@adrianbenavides Any thoughts on this?

[adrianbenavides]

@nazmulidris I don't know how to make node deletion fail, so I haven't tested the failed scenario. If you have any advice, I could try it.

The easiest way would be to manually delete the pid file in the node's state directory before deleting it through the command.

[mickm3n]

Thanks for your review. I'll check.

[mickm3n]

Hi @adrianbenavides, I fix all the problems in your feedback. Please help review again 🙏

I successfully triggered the failed condition by modifying the pid in the node's pid file.

However, if I remove the PID file, the result will be succeeded, but the node process will remain alive. I have no idea how to trace the problem; maybe we should create an issue.

[adrianbenavides]

Hi @adrianbenavides, I fix all the problems in your feedback. Please help review again 🙏

I successfully triggered the failed condition by modifying the pid in the node's pid file.

Yeah, that's right, you had to modify it, not remove it. Removing the PID file is expected to have no effect when removing the node, my mistake!

[adrianbenavides]

I've left some more comments. Looking pretty great so far!

[mickm3n]

@adrianbenavides, I appreciate your feedback. You saved me from the Option and iterator hell. I learned a lot. I fixed all of them; please help review them again. Many thanks!

[adrianbenavides]

Looks fantastic and ready to merge! Thank you so much for this contribution @mickm3n, will get merged soon 🥳

[nazmulidris]

Looks great to me! 🎉