feat(rust): return better error message when using project ticket unenrolled
#6891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianbenavides
force-pushed
the
adrian/improve-error-message-unenrolled-project-ticket
branch
from
9932ba4
to
008d48e
Compare
etorreborre
previously approved these changes
Nov 11, 2023
adrianbenavides
force-pushed
the
adrian/improve-error-message-unenrolled-project-ticket
branch
from
008d48e
to
8032949
Compare
etorreborre
approved these changes
Nov 11, 2023
|
After investigating this in detail, this PR should probably be closed. As described in this test, we can create a standalone, local authority that can use the So, the current error that we return is the most general error we can give. Perhaps we should extend the message returned when the project is not found, advising the user to enroll. The local authority use case is probably too advanced to have a tailored message for that case. What do you think? |
auto-merge was automatically disabled
November 30, 2023 17:12
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lands #6806
Fixes #5226