Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rust):vault delete interactive #6912

Conversation

Darioazzali
Copy link
Contributor

Should fix #6462.

Current behavior

Actually when the user uses the vault delete sub-command with no arguments a usage error is displayed, asking the user to give a vault name.

Proposed changes

Using the tuify crate and implementing the DeleteCommandTui trait on the vault delete sub-command, when the terminal is interactive and no arguments are passed, the user is now asked to select one or multiple vault between the existing ones.
A prompt is then shown to confirm the deletion
Should fix #6462.

Checks

  • All commits in this Pull Request are signed and Verified by Github.
  • All commits in this Pull Request follow the Ockam commit message convention.
  • There are no Merge commits in this Pull Request. Ockam repo maintains a linear commit history. We merge Pull Requests by rebasing them onto the develop branch. Rebasing to the latest develop branch and force pushing to your Pull Request branch is okay.
  • I have read and accept the Ockam Community Code of Conduct.
  • I have read and accepted the Ockam Contributor License Agreement by adding my Git/Github details in a row at the end of the CONTRIBUTORS.csv file in a separate pull request to the build-trust/ockam repository. The easiest way to do this is to edit the CONTRIBUTORS.csv file in the github web UI and create a separate Pull Request, this will mark the commit as verified.

@Darioazzali Darioazzali requested a review from a team as a code owner November 17, 2023 08:43
@Darioazzali Darioazzali changed the title Darioazzali/vault delete interactive feat(rust):vault delete interactive Nov 22, 2023
Copy link
Member

@adrianbenavides adrianbenavides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Darioazzali I've left some comments, I think all of them overlap with the comments of your other PR's.

Thanks again for your help with these issues!

Copy link
Member

@adrianbenavides adrianbenavides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge, thanks a lot for your help @Darioazzali!!

@adrianbenavides adrianbenavides added this pull request to the merge queue Nov 27, 2023
Merged via the queue into build-trust:develop with commit 14a74fe Nov 27, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants