Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redefine how we build and use Ockam NIFs #7626

Merged
merged 13 commits into from
Mar 6, 2024
Merged

Redefine how we build and use Ockam NIFs #7626

merged 13 commits into from
Mar 6, 2024

Conversation

metaclips
Copy link
Member

@metaclips metaclips commented Feb 21, 2024

  • Move the Ockly crate to the Ockam workspace and rename
  • See if rust_precompiled can simplify building and using a precompiled NIFs
  • Only build the Rust NIF once and use across CI tests
  • Build NIFs during release both for aarch64-unknown-linux-gnu and x86_64-unknown-linux-gnu so that they are usable across docker and linux system

We force build a NIF by default, to use a precompiled NIF, we have to set OCKAM_DOWNLOAD_NIF=1 which will use a precomipled NIF I created in my personal repository https://github.com/metaclips/ockam/releases/tag/ockam_v0.117.0.

@metaclips metaclips force-pushed the metaclips/ockly branch 21 times, most recently from a32b684 to 58cfcb0 Compare March 2, 2024 23:17
@metaclips metaclips force-pushed the metaclips/ockly branch 5 times, most recently from 116a8bf to 52b01fc Compare March 4, 2024 16:47
@metaclips metaclips force-pushed the metaclips/ockly branch 5 times, most recently from 78e0615 to f69a441 Compare March 6, 2024 16:42
@metaclips metaclips marked this pull request as ready for review March 6, 2024 17:05
@metaclips metaclips requested a review from a team as a code owner March 6, 2024 17:05
@metaclips
Copy link
Member Author

Ready for review @polvorin

@metaclips metaclips added this pull request to the merge queue Mar 6, 2024
Merged via the queue into develop with commit d527dac Mar 6, 2024
40 checks passed
@metaclips metaclips deleted the metaclips/ockly branch March 6, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants