Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing pdjson.h in installation #5

Open
r-burns opened this issue Sep 10, 2023 · 0 comments
Open

Missing pdjson.h in installation #5

r-burns opened this issue Sep 10, 2023 · 0 comments

Comments

@r-burns
Copy link

r-burns commented Sep 10, 2023

Hi! I'm updating Nixpkgs's various build2 packages from 0.15.0 to 0.16.0 and noticed this build failure when trying to bump bpkg:

In file included from /build/bpkg-0.16.0/bpkg/system-package-manager.cxx:10:
/nix/store/czjlc837wncb400i61arfv0v9f6wms5z-libbutl-0.16.0-dev/include/libbutl/json/parser.hxx:19:10: fatal error: libbutl/json/pdjson.h: No such file or directory
   19 | #include <libbutl/json/pdjson.h> // Implementation details.
      |          ^~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
error: process g++ exited with code 1

It looks to me like the pdjson.h header is now needed by bpkg but is not installed by libbutl's buildfiles. I was able to work around it with this small patch to also install libbutl's .h files, although I'm not sure if this is the correct solution:

--- a/libbutl/buildfile
+++ b/libbutl/buildfile
@@ -1,7 +1,7 @@
 # file      : libbutl/buildfile
 # license   : MIT; see accompanying LICENSE file
 
-lib{butl}: {hxx ixx txx cxx}{** -uuid-* +uuid-io         \
+lib{butl}: {h hxx ixx txx cxx}{** -uuid-* +uuid-io       \
                                 -win32-utility           \
                                 -mingw-*                 \
                                 -version                 \
@@ -154,7 +154,7 @@ else
 # Install into the libbutl/ subdirectory of, say, /usr/include/
 # recreating subdirectories.
 #
-{hxx ixx txx}{*}:
+{h hxx ixx txx}{*}:
 {
   install         = include/libbutl/
   install.subdirs = true
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant