Fix application profile sync category and paramater issues #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Prowlarr plugin currently uses the default indexer categories API function to get the available categories for application profiles. We were not reading the output from this function properly, resulting in category group values (e.g. `TV`, `Movies`) parsing as invalid in Buildarr, when they are actually selectable in Prowlarr. Switch to getting the available category values from the application profile schema itself, as it presents all selectable group values in the expected format. This also eliminates the usage of non-application profile related API functions in the application profile handling code.
|
Successfully parsed a Radarr indexer with category $ poetry run buildarr prowlarr dump-config http://localhost:9696
Prowlarr instance API key:
hostname: localhost
port: 9696
protocol: http
api_key: <snip>
image: lscr.io/linuxserver/prowlarr
version: 1.8.6.3946
settings:
indexers:
indexers:
delete_unmanaged: false
definitions:
...
proxies:
delete_unmanaged: false
definitions:
FlareSolverr:
type: flaresolverr
tags:
- cloudflare
host_url: http://flaresolverr:8191
request_timeout: 60
apps:
applications:
delete_unmanaged: false
definitions:
Radarr (4K Movies):
type: radarr
prowlarr_url: http://prowlarr:9696
base_url: http://radarr-4k:7878
sync_level: full-sync
sync_categories:
- movies/web-dl
- movies
- movies/uhd
- movies/foreign
- movies/bluray
- movies/other
tags:
- movies
instance_name: null
api_key: <snip>
Radarr (Anime Movies):
type: radarr
prowlarr_url: http://prowlarr:9696
base_url: http://radarr-anime:7878
sync_level: full-sync
sync_categories:
- movies/web-dl
- movies/sd
- movies/dvd
- movies/hd
- movies/foreign
- movies/bluray
- movies/other
tags:
- anime-movies
instance_name: null
api_key: <snip>
Radarr (HD/SD Movies):
type: radarr
prowlarr_url: http://prowlarr:9696
base_url: http://radarr-hd:7878
sync_level: full-sync
sync_categories:
- movies/web-dl
- movies/sd
- movies/dvd
- movies/hd
- movies/foreign
- movies/bluray
- movies/other
tags:
- movies
instance_name: null
api_key: <snip>
Sonarr (4K Shows):
type: sonarr
prowlarr_url: http://prowlarr:9696
base_url: http://sonarr-4k:8989
sync_level: full-sync
sync_categories:
- tv/uhd
- tv/foreign
- tv/other
- tv/web-dl
tags:
- shows
instance_name: null
api_key: <snip>
anime_sync_categories: []
Sonarr (Anime Shows):
type: sonarr
prowlarr_url: http://prowlarr:9696
base_url: http://sonarr-anime:8989
sync_level: full-sync
sync_categories:
- tv/anime
tags:
- anime-shows
instance_name: null
api_key: <snip>
anime_sync_categories:
- tv/anime
Sonarr (HD/SD Shows):
type: sonarr
prowlarr_url: http://prowlarr:9696
base_url: http://sonarr-hd:8989
sync_level: full-sync
sync_categories:
- tv/sd
- tv/foreign
- tv/other
- tv/web-dl
- tv/hd
tags:
- shows
instance_name: null
api_key: <snip>
anime_sync_categories: []
sync_profiles:
delete_unmanaged: false
definitions:
Standard:
enable_rss: true
enable_interactive_search: true
enable_automatic_search: true
minimum_seeders: 1
download_clients:
delete_unmanaged: false
definitions:
Transmission (Prowlarr):
enable: true
priority: 1
tags: []
host: transmission
port: 9091
use_ssl: false
url_base: /transmission/
username: null
password: null
category: null
directory: /data/torrents/prowlarr
client_priority: last
add_paused: false
type: transmission
tags:
definitions:
- cloudflare
- movies
- shows
- anime-movies
- anime-shows
general:
host:
bind_address: '*'
port: 9696
ssl_port: 6969
use_ssl: false
ssl_cert_path: null
ssl_cert_password: null
url_base: null
instance_name: Prowlarr
security:
authentication: basic
authentication_required: local-disabled
username: admin
password: <snip>
certificate_validation: enabled
proxy:
enable: false
proxy_type: http
hostname: null
port: 8080
username: null
password: null
ignored_addresses: []
bypass_proxy_for_local_addresses: true
logging:
log_level: DEBUG
analytics:
send_anonymous_usage_data: false
updates:
branch: master
automatic: false
mechanism: docker
script_path: null
backup:
folder: Backups
interval: 7
retention: 28
ui:
first_day_of_week: monday
week_column_header: day-first
short_date_format: word-month-second
long_date_format: day-first
time_format: twentyfour-hour
show_relative_dates: true
enable_color_impaired_mode: false
theme: auto
ui_language: en |
|
During testing, I found that the |
|
Tested Prowlarr instance updates working. |
Callum027
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Prowlarr plugin currently uses the default indexer categories API function to get the available categories for application profiles.
We were not reading the output from this function properly, resulting in category group values (e.g.
TV,Movies) parsing as invalid in Buildarr, when they are actually selectable in Prowlarr.Switch to getting the available category values from the application profile schema itself, as it presents all selectable group values in the expected format. This also eliminates the usage of non-application profile related API functions in the application profile handling code.
Implement the
sync_anime_standard_format_searchparameter for Sonarr application definitions, to allow managing that parameter on Prowlarr.