Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve CLI and secrets type handling #5

Merged
merged 1 commit into from
Sep 9, 2023
Merged

Improve CLI and secrets type handling #5

merged 1 commit into from
Sep 9, 2023

Conversation

Callum027
Copy link
Member

  • Parse the instance URL directly as a URL object when dumping configuration
  • Eliminate the use of cast where possible in the CLI and secrets models

@Callum027
Improve CLI and secrets type handling
f82b042 
* Parse the instance URL directly as a URL object when dumping configuration
* Eliminate the use of `cast` where possible in the CLI and secrets models
@Callum027 Callum027 added the enhancement New feature or request label Sep 9, 2023
@Callum027 Callum027 added this to the v0.1.1 milestone Sep 9, 2023
@Callum027 Callum027 self-assigned this Sep 9, 2023
@Callum027 Callum027 linked an issue Sep 9, 2023 that may be closed by this pull request
Use urllib.parse.urlparse directly in the dump-config command #3
Closed
@Callum027 Callum027 merged commit 1b31dc9 into main Sep 9, 2023
1 check passed
@Callum027 Callum027 deleted the 3-urllib-parse branch September 9, 2023 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Callum027 Callum027

Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.1.1
Development

Successfully merging this pull request may close these issues.

Use urllib.parse.urlparse directly in the dump-config command
1 participant
@Callum027