Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Sonarr instance URL base support #44

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Add Sonarr instance URL base support #44

merged 1 commit into from
Dec 1, 2023

Conversation

Callum027
Copy link
Member

@Callum027 Callum027 commented Dec 1, 2023 •
edited

#43

  • Add the url_base host configuration attribute.
  • When dumping host configurations, use the provided path as the URL base.
  • Read and store the instance version as secrets metadata (instead of fetching it in a separate API request when creating the instance configuration). Necessary for future Sonarr V4 support.

@Callum027
Add Sonarr instance URL base support
2ffeac3 
* Add the `url_base` host configuration attribute.
* When dumping host configurations, use the provided path as the URL base.
* Read and store the instance version as secrets metadata (instead of fetching it in a separate API request when creating the instance configuration). Necessary for future Sonarr V4 support.
@Callum027 Callum027 added the enhancement New feature or request label Dec 1, 2023
@Callum027 Callum027 added this to the v0.6.3 milestone Dec 1, 2023
@Callum027 Callum027 self-assigned this Dec 1, 2023
@Callum027 Callum027 linked an issue Dec 1, 2023 that may be closed by this pull request
Add Sonarr instance URL base support #43
Closed
@Callum027 Callum027 merged commit b88d9e6 into main Dec 1, 2023
1 check passed
@Callum027 Callum027 deleted the 43-url-base branch December 1, 2023 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Callum027 Callum027

Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.6.3
Development

Successfully merging this pull request may close these issues.

Add Sonarr instance URL base support
1 participant
@Callum027