Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set validate_assignment to True by default for config models #115

Merged
merged 1 commit into from
Apr 15, 2023
Merged

Set validate_assignment to True by default for config models #115

merged 1 commit into from
Apr 15, 2023

Conversation

Callum027
Copy link
Member

This removes the need to manually define validate_assignment = True on any configuration object that in-place modifies its own attributes at any point.

@Callum027 Callum027 added enhancement New feature or request plugins Vendored plugin or plugin API-related issue or pull request config Issue or pull request related to Buildarr or plugin configuration labels Apr 15, 2023
@Callum027 Callum027 added this to the v0.5.0 milestone Apr 15, 2023
@Callum027 Callum027 self-assigned this Apr 15, 2023
@Callum027 Callum027 linked an issue Apr 15, 2023 that may be closed by this pull request
Set validate_assignment to True by default on configuration models #107
Closed
@Callum027 Callum027 merged commit 330de45 into main Apr 15, 2023
1 check passed
@Callum027 Callum027 deleted the 107-validate_assignment-default-true branch April 15, 2023 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Callum027 Callum027

Labels
config Issue or pull request related to Buildarr or plugin configuration enhancement New feature or request plugins Vendored plugin or plugin API-related issue or pull request
Projects
None yet
Milestone
v0.5.0
Development

Successfully merging this pull request may close these issues.

Set validate_assignment to True by default on configuration models
1 participant
@Callum027