Clean up and update Sonarr plugin internals #14
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the internal implementation of the Sonarr plugin to use the latest plugin API interfaces and be more inline with the up-to-date Dummy reference plugin.
buildarr.plugins.sonarr.api
SonarrSecrets
fromget_initialize_js
, and take in host URL and API key as normalSonarrConfig
andSonarrSecrets
use the generic interface, and replace base class type definitions with specific onesSonarrConfig
intoSonarrInstanceConfig
(instance-specific) andSonarrConfig
(global)plugin.py
andcli.py
initialize.js
response parsing regex as a pre-compiledre.Pattern
(INITIALIZE_JS_RES_PATTERN
)