-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow any configuration value to be defined in any file #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Disable model validation for configuration files on the initial pass (while still parsing them into objects) * Change `LocalPath` to parse relative paths to absolute paths on object creation, instead of validation (to make sure it is *always* validated, even when validation is disabled)
Callum027
added
enhancement
New feature or request
config
Issue or pull request related to Buildarr or plugin configuration
labels
Nov 7, 2023
Tested working.
---
includes:
- sonarr.yml
- radarr.yml
- prowlarr.yml
- jellyseerr.yml
- config2/buildarr-2.yml
buildarr:
watch_config: false # Tell Buildarr to reload using SIGHUP.
update_days:
- "monday"
- "tuesday"
- "wednesday"
- "thursday"
- "friday"
- "saturday"
- "sunday"
update_times:
- "03:00"
request_timeout: 30
# secrets_file_path: "secrets.json"
---
buildarr:
secrets_file_path: "secrets2.json"
---
includes:
- config2/prowlarr-2.yml
prowlarr:
instances:
prowlarr:
api_key: <snip>
settings:
indexers:
indexers:
definitions:
"Nyaa.si":
type: nyaasi
enable: true
sync_profile: Standard
redirect: false
priority: 15
grab_limit: 50 # 104
query_limit: 10010
tags:
- shows
- movies
- anime-shows
- anime-movies
fields:
torrentBaseSettings.seedRatio: null
prefer_magnet_links: true
---
prowlarr:
instances:
prowlarr:
settings:
indexers:
indexers:
definitions:
"Nyaa.si":
# The following are normally required, but not defined in the included file, to demonstrate the changes work.
# type: nyaasi
# sync_profile: Standard
grab_limit: 104
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
config
Issue or pull request related to Buildarr or plugin configuration
enhancement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the initial per-file validation of configuration files into a non-validating parsing and expansion of
LocalPath
attributes based on the dynamically generated Pydantic model.This allows validation of only
LocalPath
type attributes while not validating anything else until the combined configuration structure is loaded properly.With this change, the limitation where individual configuration files need to be syntatically correct on its own has now been lifted. The combined files being loaded, as a set, being correct is sufficient.