Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve and fix Sonarr general settings configuration updates #19

Merged
merged 1 commit into from
Feb 18, 2023

Conversation

Callum027
Copy link
Member

@Callum027 Callum027 commented Feb 18, 2023

This fixes the remaining issues for pushing configuration updates for Sonarr general settings.

  • Fix updates for sonarr.settings.general.proxy.password.
  • Improve Sonarr instance authentication username and password handling so that it more closely matches the Sonarr instance state:
    • Sonarr does not set the username and password back to blank values once set to a non-zero value, even when authentication is also disabled.
    • To handle this, implement a validator that enforces the following conditions:
      • When authentication is explicitly disabled in either Buildarr or the remote Sonarr instance, set the username and password to None. This prevents meaningless configuration updates from Buildarr from occurring.
      • Require the username and password to be set to a non-empty value if authentication is enabled in Buildarr.
  • Fix a definition of sonarr.settings.general.security.authentication mistakenly set as authentication_method in the documentation.

@Callum027 Callum027 added bug Something isn't working testing Testing-related issue or pull request labels Feb 18, 2023
@Callum027 Callum027 added this to the v0.1.2 milestone Feb 18, 2023
@Callum027 Callum027 self-assigned this Feb 18, 2023
@Callum027 Callum027 merged commit b939db8 into main Feb 18, 2023
@Callum027 Callum027 deleted the 2-sonarr-settings-general-2 branch February 18, 2023 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working testing Testing-related issue or pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant