Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Sonarr media management settings and improve root folder handling #24

Merged
merged 1 commit into from
Feb 19, 2023

Conversation

Callum027
Copy link
Member

This fixes a number of bugs with loading and setting media management configuration in Sonarr.

Add a new delete_unmanaged_root_folders configuration attribute to the media management block, to enable automatic deletion of root folders not explicitly defined in Buildarr.

  • Constrain minimum_free_space to the minimum allowed value of 100 MB, as enforced by Sonarr
  • Set chown_group to be of type Optional[str] to allow empty strings to be defined (handled the same as None)
  • Change root_folders to be of type Set[NonEmptyStr] to ensure only unique values are handled internally
  • Add the delete_unmanaged_root_folders attribute for allowing automatic deletion of root folders in Sonarr not defined in Buildarr
  • Add the missing unmonitor_deleted_episodes to the remote map entries, causing it to not be read from Sonarr or updated when defined in Buildarr
  • Fix the root folder tree printed in logging messages to contain root_folders

@Callum027 Callum027 merged commit e8e7437 into main Feb 19, 2023
@Callum027 Callum027 deleted the 2-sonarr-settings-mediamanagement branch February 19, 2023 09:59
@Callum027 Callum027 self-assigned this Feb 19, 2023
@Callum027 Callum027 added bug Something isn't working enhancement New feature or request testing Testing-related issue or pull request labels Feb 19, 2023
@Callum027 Callum027 added this to the v0.1.2 milestone Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request testing Testing-related issue or pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant