Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement testing of cached and fetched instance secrets #32

Merged
merged 1 commit into from
Feb 21, 2023
Merged

Implement testing of cached and fetched instance secrets #32

merged 1 commit into from
Feb 21, 2023

Conversation

Callum027
Copy link
Member

  • Add the abstract method for SecretsPlugin.get and implement it in the vendored plugins
  • Add logic for testing cached secrets, and if the test fails or the secrets are not cached, fetch them and test again
  • If even the fetched secrets fail the test, raise an error

@Callum027 Callum027 added enhancement New feature or request plugins Vendored plugin or plugin API-related issue or pull request labels Feb 21, 2023
@Callum027 Callum027 added this to the v0.2.0 milestone Feb 21, 2023
@Callum027 Callum027 self-assigned this Feb 21, 2023
@Callum027 Callum027 linked an issue Feb 21, 2023 that may be closed by this pull request
Implement testing of cached and fetched instance secrets #31
Closed
@Callum027 Callum027 merged commit adf6675 into main Feb 21, 2023
@Callum027 Callum027 deleted the 31-secrets-testing branch February 21, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Callum027 Callum027

Labels
enhancement New feature or request plugins Vendored plugin or plugin API-related issue or pull request
Projects
None yet
Milestone
v0.2.0
Development

Successfully merging this pull request may close these issues.

Implement testing of cached and fetched instance secrets
1 participant
@Callum027