Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set better constraints on Sonarr configuration attributes #38

Merged
merged 1 commit into from
Feb 22, 2023
Merged

Set better constraints on Sonarr configuration attributes #38

merged 1 commit into from
Feb 22, 2023

Conversation

Callum027
Copy link
Member

@Callum027 Callum027 commented Feb 22, 2023 •
edited

  • Change the following to use sets instead of lists to handle duplicate elements:
    • FilelistIndexer.categories
    • FilelistIndexer.anime_categories
    • DiscordConnection.on_grab_fields
    • DiscordConnection.on_import_fields
    • JoinConnection.device_names
    • PushoverConnection.devices
    • ProxyGeneralSettings.ignored_addresses (sonarr.settings.general.proxy.ignored_addresses)
  • Make sure recipient/CC/BCC addresses are unique in e-mail, Mailgun and Sendgrid connection definitions
  • Require at least one recipient address to be provided in Mailgun and Sendgrid connection definitions
  • Fix typos and add missing values descriptions to the documentation

@Callum027 Callum027 added bug Something isn't working plugins Vendored plugin or plugin API-related issue or pull request labels Feb 22, 2023
@Callum027 Callum027 added this to the v0.2.0 milestone Feb 22, 2023
@Callum027 Callum027 self-assigned this Feb 22, 2023
@Callum027 Callum027 merged commit beac4e4 into main Feb 22, 2023
@Callum027 Callum027 deleted the x-sonarr-attribute-types branch February 22, 2023 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Callum027 Callum027

Labels
bug Something isn't working plugins Vendored plugin or plugin API-related issue or pull request
Projects
None yet
Milestone
v0.2.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Callum027