Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README example config - remove CircularBlobAccess #17

Closed
Cynical-Optimist opened this issue Dec 22, 2020 · 3 comments · Fixed by #16
Closed

Update README example config - remove CircularBlobAccess #17

Cynical-Optimist opened this issue Dec 22, 2020 · 3 comments · Fixed by #16

Comments

@Cynical-Optimist
Copy link

The example config quoted in the README uses CircularBlobAccess (the keyword 'circular').

CircularBlobAccess has been removed from bb-storage. And bb-remote-access has now been updated to include those changes. The README ought to be updated to use LocalBlobAccess.

@Cynical-Optimist
Copy link
Author

If it helps, this was prompted by an issue we're having on the remote-apis-testing project:

https://gitlab.com/remote-apis-testing/remote-apis-testing/-/issues/111

@EdSchouten
Copy link
Member

EdSchouten commented Dec 28, 2020

Hey there!

This part of this config file:

    circular: {
      directory: '/storage',
      offsetFileSizeBytes: 1024 * 1024,
      offsetCacheSize: 1000,
      dataFileSizeBytes: 100 * 1024 * 1024,
      dataAllocationChunkSizeBytes: 1048576,
      instances: ['remote-execution'],
    },

can be replaced with:

    'local': {
      keyLocationMapOnBlockDevice: {
        file: {
          path: '/storage/key_location_map',
          sizeBytes: 1024 * 1024,
        },
      },
      keyLocationMapMaximumGetAttempts: 8,
      keyLocationMapMaximumPutAttempts: 32,
      oldBlocks: 8,
      currentBlocks: 24,
      newBlocks: 3,
      blocksOnBlockDevice: {
        source: {
          file: {
            path: '/storage/blocks',
            sizeBytes: 100 * 1024 * 1024,
          },
        },
        spareBlocks: 3,
      },
      // Add this chunk if you also want it to be persistent across restarts. If no persistency is needed, just omit this.
      persistent: {
        stateDirectoryPath: '/storage/persistent_state',
        minimumEpochInterval: '5m',
      },
    },

And this part:

  httpListenAddress: ':7982',

Needs to be replaced with:

global: { diagnosticsHttpListenAddress: ':7982' },

@Cynical-Optimist
Copy link
Author

Cynical-Optimist commented Dec 29, 2020

Thanks @EdSchouten, I've tested that on Remote-Testing-APIs, and it works perfectly. That was a really big help!

re updating the README, I assume the same changes would apply there? (But with "/storage" changed to "/storage-asset" and "remote-execution" changed to "foo", as in the current README.)

What about the undertext though? There's a paragraph that starts "In the example above, the daemon is configured to store asset references within a disk backed circular storage backend.". The part about the circular storage backend obviously ought to be changed to something else. Does the rest need to be changed too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants