replace vacuuous mock.assert_called with mock.assert_called_with()

buildbot · Apr 17, 2014 · 0a2ffe5 · 0a2ffe5
1 parent 67e8d08
commit 0a2ffe5
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/master/buildbot/test/unit/test_schedulers_basic.py b/master/buildbot/test/unit/test_schedulers_basic.py
@@ -162,7 +162,7 @@ def test_activate_calls_preStartConsumingChanges(self):
 
         @d.addCallback
         def check(_):
-            sched.preStartConsumingChanges.assert_called()
+            sched.preStartConsumingChanges.assert_called_with()
         return d
 
     def test_gotChange_no_treeStableTimer_unimportant(self):

diff --git a/master/buildbot/test/unit/test_www_auth.py b/master/buildbot/test/unit/test_www_auth.py
@@ -196,7 +196,7 @@ def updateUserInfo(request):
         res = yield self.render_resource(self.rsrc, '/auth/login')
         self.assertEqual(res, "")
         self.failIf(self.auth.maybeAutoLogin.called)
-        self.auth.updateUserInfo.assert_called()
+        self.auth.updateUserInfo.assert_called_with(mock.ANY)
         self.assertEqual(self.master.session.user_info,
                          {'email': 'him@org', 'username': 'him'})
 
@@ -212,4 +212,4 @@ def test_render(self):
         self.master.session.expire = mock.Mock()
         res = yield self.render_resource(self.rsrc, '/auth/logout')
         self.assertEqual(res, "")
-        self.master.session.expire.assert_called()
+        self.master.session.expire.assert_called_with()
diff --git a/master/buildbot/test/unit/test_www_config.py b/master/buildbot/test/unit/test_www_config.py
@@ -33,7 +33,7 @@ def test_render(self):
         rsrc.reconfigResource(master.config)
 
         res = yield self.render_resource(rsrc, '/')
-        _auth.maybeAutoLogin.assert_called()
+        _auth.maybeAutoLogin.assert_called_with(mock.ANY)
         exp = 'this.config = {"url": "h:/a/b/", "user": {"anonymous": true}, "auth": {"name": "NoAuth"}, "port": null}'
         self.assertEqual(res, exp)