Skip to content

Commit

Permalink
Pass codebases through kwargs
Browse files Browse the repository at this point in the history
  • Loading branch information
hborkhuis committed May 1, 2012
1 parent fa0535d commit 1646b95
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 8 deletions.
6 changes: 2 additions & 4 deletions master/buildbot/schedulers/basic.py
Expand Up @@ -38,8 +38,7 @@ class NotSet: pass
def __init__(self, name, shouldntBeSet=NotSet, treeStableTimer=None,
builderNames=None, branch=NotABranch, branches=NotABranch,
fileIsImportant=None, properties={}, categories=None,
change_filter=None, onlyImportant=False,
codebases = None):
change_filter=None, onlyImportant=False, **kwargs):
if shouldntBeSet is not self.NotSet:
config.error(
"pass arguments to schedulers using keyword arguments")
Expand All @@ -48,8 +47,7 @@ def __init__(self, name, shouldntBeSet=NotSet, treeStableTimer=None,
"fileIsImportant must be a callable")

# initialize parent classes
base.BaseScheduler.__init__(self, name, builderNames, properties,
codebases=codebases)
base.BaseScheduler.__init__(self, name, builderNames, properties, **kwargs)

self.treeStableTimer = treeStableTimer
self.fileIsImportant = fileIsImportant
Expand Down
4 changes: 2 additions & 2 deletions master/buildbot/schedulers/dependent.py
Expand Up @@ -23,9 +23,9 @@ class Dependent(base.BaseScheduler):

compare_attrs = base.BaseScheduler.compare_attrs + ('upstream_name',)

def __init__(self, name, upstream, builderNames, properties={}, codebases=None):
def __init__(self, name, upstream, builderNames, properties={}, **kwargs):
base.BaseScheduler.__init__(self, name, builderNames, properties,
codebases = codebases)
**kwargs)
if not interfaces.IScheduler.providedBy(upstream):
config.error(
"upstream must be another Scheduler instance")
Expand Down
4 changes: 2 additions & 2 deletions master/buildbot/schedulers/triggerable.py
Expand Up @@ -22,9 +22,9 @@ class Triggerable(base.BaseScheduler):

compare_attrs = base.BaseScheduler.compare_attrs

def __init__(self, name, builderNames, properties={}, codebases = None):
def __init__(self, name, builderNames, properties={}, **kwargs):
base.BaseScheduler.__init__(self, name, builderNames, properties,
codebases = codebases)
**kwargs)
self._waiters = {}
self._bsc_subscription = None
self.reason = "Triggerable(%s)" % name
Expand Down

0 comments on commit 1646b95

Please sign in to comment.