Add a link to the buildslave page in the missing slave email.

Fixes #344.
buildbot · Sep 27, 2012 · 1f8139e · 1f8139e
1 parent 498375d
commit 1f8139e
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/master/buildbot/buildslave.py b/master/buildbot/buildslave.py
@@ -326,6 +326,8 @@ def _missing_timer_fired(self):
         text += "Sincerely,\n"
         text += " The Buildbot\n"
         text += " %s\n" % status.getTitleURL()
+        text += "\n"
+        text += "%s\n" % status.getURLForThing(self.slave_status)
         subject = "Buildbot: buildslave %s was lost" % self.slavename
         return self._mail_missing_message(subject, text)
 

diff --git a/master/buildbot/status/master.py b/master/buildbot/status/master.py
@@ -160,6 +160,11 @@ def getURLForThing(self, thing):
         # IBuildSetStatus
         # IBuildRequestStatus
         # ISlaveStatus
+        if interfaces.ISlaveStatus.providedBy(thing):
+            slave = thing
+            return prefix + "buildslaves/%s" % (
+                    urllib.quote(slave.getName(), safe=''),
+                    )
 
         # IStatusEvent
         if interfaces.IStatusEvent.providedBy(thing):