Merge pull request #184 from tomprince/source

Get rid of _ComputeRepositoryURL from new source steps.

From Tom's description of the pull request:

The reason for this is that _ComputeRepositoryURL has a bunch of magic to be backwards compatible with a bunch of different ways of specifying the repository. With the new renderable support, one can write code to explicitly specify any of the behaviours exposed by _ComputeRepositoryURL, with out relying on the right backwards compatibility code. I thought since we are not making the new steps entirely compatible with the old ones, it would be a good chance to get rid of the backwards compatibility magic in _ComputeRepositoryURL.

master/buildbot/steps/source/git.py

@@ -17,7 +17,7 @@
 from twisted.internet import defer
 
 from buildbot.process import buildstep
-from buildbot.steps.source import Source, _ComputeRepositoryURL
+from buildbot.steps.source import Source
 from buildbot.interfaces import BuildSlaveTooOldError
 
 class Git(Source):
@@ -86,7 +86,7 @@ def __init__(self, repourl=None, branch='master', mode='incremental',
         assert self.repourl is not None
         if self.mode == 'full':
             assert self.method in ['clean', 'fresh', 'clobber', 'copy', None]
-        self.repourl = self.repourl and _ComputeRepositoryURL(self.repourl)
+        self.repourl = self.repourl
 
     def startVC(self, branch, revision, patch):
         self.branch = branch or 'master'

master/buildbot/steps/source/mercurial.py

@@ -19,7 +19,7 @@
 from twisted.internet import defer
 
 from buildbot.process import buildstep
-from buildbot.steps.source import Source, _ComputeRepositoryURL
+from buildbot.steps.source import Source
 from buildbot.interfaces import BuildSlaveTooOldError
 
 class Mercurial(Source):
@@ -94,8 +94,8 @@ def __init__(self, repourl=None, baseURL=None, mode='incremental',
             raise ValueError("you must privide at least one of repourl and"
                              " baseURL")
 
-        self.repourl = self.repourl and _ComputeRepositoryURL(self.repourl)
-        self.baseURL = self.baseURL and _ComputeRepositoryURL(self.baseURL)
+        self.repourl = self.repourl
+        self.baseURL = self.baseURL
 
     def startVC(self, branch, revision, patch):
         self.revision = revision