Merge branch 'master' of git://github.com/flaviojs/buildbot

* 'master' of git://github.com/flaviojs/buildbot:
  Add --nodaemon to the Command-line Tool documentation.
  Add nodaemon option tests to master.
  Clarify buildbot --nodaemon.
  Clarify buildslave --nodaemon.
  Add option 'nodaemon' to buildbot start/restart.
  Add option 'nodaemon' to buildslave start/restart.

master/buildbot/scripts/runner.py

@@ -143,6 +143,7 @@ class RestartOptions(base.BasedirMixin, base.SubcommandOptions):
     subcommandFunction = "buildbot.scripts.restart.restart"
     optFlags = [
         ['quiet', 'q', "Don't display startup log messages"],
+        ['nodaemon', None, "Don't daemonize (stay in foreground)"],
         ]
     def getSynopsis(self):
         return "Usage:    buildbot restart [<basedir>]"
@@ -152,6 +153,7 @@ class StartOptions(base.BasedirMixin, base.SubcommandOptions):
     subcommandFunction = "buildbot.scripts.start.start"
     optFlags = [
         ['quiet', 'q', "Don't display startup log messages"],
+        ['nodaemon', None, "Don't daemonize (stay in foreground)"],
         ]
     def getSynopsis(self):
         return "Usage:    buildbot start [<basedir>]"

master/buildbot/scripts/start.py

@@ -71,6 +71,8 @@ def launch(config):
             "--no_save",
             "--logfile=twistd.log", # windows doesn't use the same default
             "--python=buildbot.tac"]
+    if config['nodaemon']:
+        argv.extend(['--nodaemon'])
     sys.argv = argv
 
     # this is copied from bin/twistd. twisted-2.0.0 through 2.4.0 use

master/buildbot/test/unit/test_scripts_runner.py

@@ -230,11 +230,21 @@ class TestResetartOptions(BaseTestSimpleOptions, unittest.TestCase):
     commandName = 'restart'
     optionsClass = runner.RestartOptions
 
+    def test_nodaemon(self):
+        opts = self.parse('--nodaemon')
+        exp = dict(nodaemon=True)
+        self.assertOptions(opts, exp)
+
 
 class TestStartOptions(BaseTestSimpleOptions, unittest.TestCase):
     commandName = 'start'
     optionsClass = runner.StartOptions
 
+    def test_nodaemon(self):
+        opts = self.parse('--nodaemon')
+        exp = dict(nodaemon=True)
+        self.assertOptions(opts, exp)
+
 
 class TestReconfigOptions(BaseTestSimpleOptions, unittest.TestCase):
     commandName = 'reconfig'

master/docs/manual/cmdline.rst

@@ -85,6 +85,10 @@ buildmaster administrators:
     directory. The daemon is launched in the background, with events logged
     to a file named :file:`twistd.log`.
 
+--nodaemon
+    Don't daemonize. The process will start in the foreground.
+    It will only return to the command-line when it is stopped.
+
 ``stop``
 
     This terminates the daemon (either buildmaster or buildslave) running
@@ -902,6 +906,10 @@ to a file named :file:`twistd.log`. ::
 
     buildbot start BASEDIR
 
+--nodaemon
+    Don't daemonize. The process will start in the foreground.
+    It will only return to the command-line when it is stopped.
+
 .. bb:cmdline:: stop (buildslave)
 
 stop

slave/buildslave/scripts/runner.py

@@ -269,6 +269,7 @@ def postOptions(self):
 class StartOptions(MakerBase):
     optFlags = [
         ['quiet', 'q', "Don't display startup log messages"],
+        ['nodaemon', None, "Don't daemonize (stay in foreground)"],
         ]
     def getSynopsis(self):
         return "Usage:    buildslave start [<basedir>]"
@@ -280,6 +281,7 @@ def getSynopsis(self):
 class RestartOptions(MakerBase):
     optFlags = [
         ['quiet', 'q', "Don't display startup log messages"],
+        ['nodaemon', None, "Don't daemonize (stay in foreground)"],
         ]
     def getSynopsis(self):
         return "Usage:    buildslave restart [<basedir>]"

slave/buildslave/scripts/startup.py

@@ -109,6 +109,8 @@ def launch(config):
             "--no_save",
             "--logfile=twistd.log", # windows doesn't use the same default
             "--python=buildbot.tac"]
+    if config['nodaemon']:
+        argv.extend(['--nodaemon'])
     sys.argv = argv
 
     # this is copied from bin/twistd. twisted-2.0.0 through 2.4.0 use