add a BuildStep.isNewStyle method

buildbot · Dec 16, 2013 · 3c09d04 · 3c09d04
1 parent 6a57249
commit 3c09d04
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 0 deletions.
diff --git a/master/buildbot/process/buildstep.py b/master/buildbot/process/buildstep.py
@@ -486,6 +486,10 @@ def failed(self, why):
             "failed() can only be called from old steps implementing start()"
         self._start_deferred.errback(why)
 
+    def isNewStyle(self):
+        # **temporary** method until new-style steps are the only supported style
+        return self.run.__func__ is not BuildStep.run.__func__
+
     def start(self):
         raise NotImplementedError("your subclass must implement run()")
 

diff --git a/master/buildbot/test/unit/test_process_buildstep.py b/master/buildbot/test/unit/test_process_buildstep.py
@@ -51,6 +51,18 @@ class FakeStepStatus:
     pass
 
 
+class OldStyleStep(buildstep.BuildStep):
+
+    def start(self):
+        pass
+
+
+class NewStyleStep(buildstep.BuildStep):
+
+    def run(self):
+        pass
+
+
 class TestRegexLogEvaluator(unittest.TestCase):
 
     def makeRemoteCommand(self, rc, stdout, stderr=''):
@@ -340,6 +352,10 @@ def test_getStatistics(self):
         step.setStatistic('ba', 0.298)
         self.assertEqual(step.getStatistics(), {'rbi': 13, 'ba': 0.298})
 
+    def test_isNewStyle(self):
+        self.assertFalse(OldStyleStep().isNewStyle())
+        self.assertTrue(NewStyleStep().isNewStyle())
+
 
 class TestLoggingBuildStep(unittest.TestCase):