Merge pull request #5006 from tardyp/release

relnotes for 2.4.1
buildbot · Sep 11, 2019 · 4ff21d4 · 4ff21d4
2 parents 2d8974a + f172c54
commit 4ff21d4
Show file tree

Hide file tree

Showing 10 changed files with 27 additions and 15 deletions.
diff --git a/.bbtravis.yml b/.bbtravis.yml
@@ -188,13 +188,13 @@ script:
     condition: TESTS == "smokes"
     cmd: make tarballs
 
-  - title: protractor tests
-    condition: TESTS == "smokes"
-    cmd: ./common/smokedist.sh whl
+  # - title: protractor tests
+  #   condition: TESTS == "smokes"
+  #   cmd: ./common/smokedist.sh whl
 
-  - title: tarballs protractor tests
-    condition: TESTS == "smokes" and not TRAVIS_PULL_REQUEST
-    cmd: ./common/smokedist.sh tar.gz
+  # - title: tarballs protractor tests
+  #   condition: TESTS == "smokes" and not TRAVIS_PULL_REQUEST
+  #   cmd: ./common/smokedist.sh tar.gz
 
 notifications:
   email: false

diff --git a/master/buildbot/newsfragments/committer_nullable.bugfix b/master/buildbot/newsfragments/committer_nullable.bugfix
diff --git a/master/buildbot/newsfragments/custom_templates.bugfix b/master/buildbot/newsfragments/custom_templates.bugfix
diff --git a/master/buildbot/newsfragments/improve_log_clean_performance.feature b/master/buildbot/newsfragments/improve_log_clean_performance.feature
diff --git a/master/buildbot/newsfragments/inactive_hide_waterfall.feature b/master/buildbot/newsfragments/inactive_hide_waterfall.feature
diff --git a/master/buildbot/newsfragments/locks-reconfig-no-extra-claims.bugfix b/master/buildbot/newsfragments/locks-reconfig-no-extra-claims.bugfix
diff --git a/master/docs/relnotes/index.rst b/master/docs/relnotes/index.rst
@@ -10,6 +10,23 @@ Release Notes
 
 .. towncrier release notes start
 
+Buildbot ``2.4.1`` ( ``2019-09-11`` )
+=====================================
+
+Bug fixes
+---------
+
+- allow committer of a change to be null for new setups (:issue:`4987`)
+- custom_templates are now working again.
+- Locks will no longer allow being acquired more times than the `maxCount` parameter if this parameter is changed during master reconfiguration.
+
+Features
+--------
+
+- Improve log cleaning performance by using delete with join on supported databases.
+- Hiding/showing of inactive builders is now possible in Waterfall view.
+
+
 Buildbot ``2.4.0`` ( ``2019-08-18`` )
 =====================================
 

diff --git a/smokes/e2e/pages/base.ts b/smokes/e2e/pages/base.ts
@@ -12,13 +12,13 @@ export class BasePage {
     async logOut() {
         await element(By.css('.avatar img')).click();
         await element(By.linkText('Logout')).click();
-        const anonymousButton = element(By.css('.dropdown'));
+        const anonymousButton = element.all(By.css('.dropdown')).first();
         expect(await anonymousButton.getText()).toContain("Anonymous");
     }
 
     async loginUser(user, password) {
         await browser.get(`http://${user}:${password}@localhost:8011/auth/login`);
-        const anonymousButton = element(By.css('.dropdown'));
+        const anonymousButton = element.all(By.css('.dropdown')).first();
         expect(await anonymousButton.getText()).not.toContain("Anonymous");
     }
 }
diff --git a/smokes/protractor-headless.conf.js b/smokes/protractor-headless.conf.js
@@ -22,7 +22,7 @@ exports.config = {
                 '--headless',
                 '--disable-gpu',
                 '--no-sandbox',
-                '--window-size=1024,768',
+                '--window-size=1200,1024',
                 '--user-agent="Mozilla/5.0 (Windows NT 10.0; Win64; x64) Chrome/56.0.2924.87"',
             ]
         }

diff --git a/smokes/protractor.conf.js b/smokes/protractor.conf.js
@@ -21,7 +21,7 @@ exports.config = {
             // minimal supported browser size for tests
             // if smaller we start need to scroll for clicking buttons
             args: [
-                '--window-size=1024,768',
+                '--window-size=1200,1024',
                 '--user-agent="Mozilla/5.0 (Windows NT 10.0; Win64; x64) Chrome/56.0.2924.87"',
             ]
         }