fix XSS vulnerability reported by Nicolas Sylvain <nsylvain@google.com>

buildbot · Aug 12, 2009 · 53f3787 · 53f3787
1 parent c70ee21
commit 53f3787
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/buildbot/status/web/waterfall.py b/buildbot/status/web/waterfall.py
@@ -584,7 +584,7 @@ def with_args(req, remove_args=[], new_args=[], new_path=None):
                     newargs[k].append(v)
                 else:
                     newargs[k] = [v]
-            newquery = "&".join(["%s=%s" % (k, v)
+            newquery = "&".join(["%s=%s" % (k, urllib.quote(v))
                                  for k in newargs
                                  for v in newargs[k]
                                  ])