Skip to content

Commit

Permalink
Add notes for BuildSlave subclassers re: canStartBuild
Browse files Browse the repository at this point in the history
Refs #2056.
  • Loading branch information
djmitche committed Jul 30, 2011
1 parent 6b3dc39 commit 6fdf5fb
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions master/buildbot/buildslave.py
Expand Up @@ -486,6 +486,12 @@ def canStartBuild(self):
I am called when a build is requested to see if this buildslave
can start a build. This function can be used to limit overall
concurrency on the buildslave.
Note for subclassers: if a slave can become willing to start a build
without any action on that slave (for example, by a resource in use on
another slave becoming available), then you must arrange for
L{maybeStartBuildsForSlave} to be called at that time, or builds on
this slave will not start.
"""
# If we're waiting to shutdown gracefully, then we shouldn't
# accept any new jobs.
Expand Down

0 comments on commit 6fdf5fb

Please sign in to comment.