Skip to content

Commit

Permalink
enable pylint 'assignment-from-no-return' check
Browse files Browse the repository at this point in the history
Pylint reports one false positive 'assigning from a function
without a return' error. Disable the check locally there,
and enable it globaly.
  • Loading branch information
Elmir Jagudin committed Aug 24, 2013
1 parent e81d6bd commit 7af8fd4
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
1 change: 0 additions & 1 deletion common/pylintrc
Expand Up @@ -101,7 +101,6 @@ disable=
E1002,
E1101,
E1102,
E1111,
E1120,
E1121,
E1123,
Expand Down
3 changes: 2 additions & 1 deletion master/buildbot/test/unit/test_util_misc.py
Expand Up @@ -54,7 +54,8 @@ def test_fn_exception(self):
@util.deferredLocked(l)
def do_fail():
raise RuntimeError("oh noes")
d = do_fail()
# using decorators confuses pylint and gives a false positive below
d = do_fail() # pylint: disable=assignment-from-no-return
def check_unlocked(_):
self.assertFalse(l.locked)
d.addCallbacks(lambda _ : self.fail("didn't errback"),
Expand Down

0 comments on commit 7af8fd4

Please sign in to comment.